CMake minimum version not compatible with recent changes in hunter

[nasosi]

Hello,
The introduction of ALIAS of imported targets in hunter (and in particular in zlib, png and freetype) has elevated the CMake minimum version requirement. The minimum version should be now 3.11 and not 3.2.

Demonstration of the issue (cmake 3.10.3):
Github bug repository

Travis: link

Thank you!
-Nasos

Edit:typo

[bkotzz]

Thank you for reporting this. Would you like to make a PR to raise the minimum version requirement?

[nasosi]

There are a couple of places that the requirement may be applied:

1. Hunter wide: This would be fairly easy and probably require changing:

• HunterGate check for minimum requirement
• Relevant documentation

2. On a per package base. Currently only zlib, png and freetype are affected.

Issue with 1: Moving to a cmake version that is about 1.5 years old may make people unhappy.
Issue with 2: Need to manage cmake version requirement on a per package basis.

I think (2) is more proper for now. Maybe backlog (1) for like 2 years from now.

I will go with (2) if there are no objections.

Also is https://github.com/hunter-packages the repository for updating patched packages?

[rbsheth]

Okay, seems reasonable. https://github.com/cpp-pm is the new repository for updating packages - let us know which package forks to copy from hunter-packages and we'll do it.

[nasosi]

Ok
So it is: zlib, png and freetype.
Can you also copy over bzip2 that has another minor issue?
-N

[rbsheth]

@nasosi Done!

https://github.com/cpp-pm/zlib
https://github.com/cpp-pm/libpng
https://github.com/cpp-pm/freetype
https://github.com/cpp-pm/bzip2

[cristianadam]

The reason for the aliases is the FindModule packages naming scheme from upstream CMake. I don't know how many FindModule packages, from the ~150 that CMake has, have target names, have counterparts in cpp-pm, with different target names.

See https://gitlab.kitware.com/cmake/cmake/issues/19287 for more information.

[caseymcc]

Sorry just now running into this issue so coming in late. Considering the default on Ubuntu 18.04 is cmake 3.10.3, why don't we just check the version of cmake and only use the alias if it 3.11 or higher? Anyone using anything lower will just have to use the imported name.

[NeroBurner]

closing old stale thread

we're now at CMake 3.10 minimum: #769