-
Notifications
You must be signed in to change notification settings - Fork 192
check and fix packages urls #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NeroBurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this contribution! Checking the download URLs is a VERY good idea!
I'd like to extend the script a bit. Maybe it would be a good idea to check the projects when they are changed in the CI. On the one hand checking the project URL when a contributor comes along and gets a seemingly unconnected error because of an old package URL. Otherwise it would be great to check the URLs somewhere/somewhen
@rbsheth what do you think?
Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only question left for me is if and how we can include this marvelous piece of code in the CI 🤔
its possible to include this script into build.sh/cmd. add an exit code to it, or just check if 'checked.txt' file is present and zero size |
Yeah, it would be useful to weed out broken packages. We can add it to CI |
|
created a new Issue for the adding of the script to the CI |
This fixes: #546 #540 and #191