Skip to content

Conversation

@drodin
Copy link
Member

@drodin drodin commented Jun 13, 2022

  • script to go through packages and check if urls are still valid
  • manual clean up of non existent/changed urls
  • some cosmetic fixes for easier automation checks on packages

This fixes: #546 #540 and #191

Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution! Checking the download URLs is a VERY good idea!

I'd like to extend the script a bit. Maybe it would be a good idea to check the projects when they are changed in the CI. On the one hand checking the project URL when a contributor comes along and gets a seemingly unconnected error because of an old package URL. Otherwise it would be great to check the URLs somewhere/somewhen

@rbsheth what do you think?

drodin and others added 2 commits June 13, 2022 16:09
Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question left for me is if and how we can include this marvelous piece of code in the CI 🤔

@drodin
Copy link
Member Author

drodin commented Jun 15, 2022

LGTM, only question left for me is if and how we can include this marvelous piece of code in the CI 🤔

its possible to include this script into build.sh/cmd. add an exit code to it, or just check if 'checked.txt' file is present and zero size

@rbsheth
Copy link
Member

rbsheth commented Jun 16, 2022

Thank you very much for this contribution! Checking the download URLs is a VERY good idea!

I'd like to extend the script a bit. Maybe it would be a good idea to check the projects when they are changed in the CI. On the one hand checking the project URL when a contributor comes along and gets a seemingly unconnected error because of an old package URL. Otherwise it would be great to check the URLs somewhere/somewhen

@rbsheth what do you think?

Yeah, it would be useful to weed out broken packages. We can add it to CI

@NeroBurner NeroBurner merged commit d4f3a43 into cpp-pm:master Aug 18, 2022
@NeroBurner
Copy link

created a new Issue for the adding of the script to the CI

#598

@NeroBurner
Copy link

@drodin drodin deleted the pr.clean_up branch September 14, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boost path is broken - Quickstart doesn't work

3 participants