Skip to content

Conversation

@Dargun
Copy link

@Dargun Dargun commented Jul 4, 2022

  • I've followed this guide
    step by step carefully. [Yes|No]

  • I've followed this guide
    step by step carefully. [Yes}

  • I've checked this Git style guide. [Yes}
  • I've checked this CMake style guide. [Yes}
  • My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes|No]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes}

Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeroBurner NeroBurner merged commit 08b2aa3 into cpp-pm:master Jul 4, 2022
@Dargun
Copy link
Author

Dargun commented Jul 4, 2022

seems there are some test in general failing or has that todo with my change?

@NeroBurner
Copy link

From https://cpp-pm.github.io/hunter/ it seems the nmake and ninja builds were skipped (marked blue). Only the VS16 windows build was reliably working (and still does work)

test matrix OpenSSL

The failing pipelines are related to VS16 with nmake and ninja, as well as mingw builds on Windows. It doesn't look like your change did that. I assume the schema for OpenSSL needs to be updated to handle the new compiler/environments

failing vs16 tests

@NeroBurner
Copy link

created issue with more information for interested people to investigate #591

@Dargun Dargun deleted the openssl-emscripten branch July 4, 2022 16:36
@NeroBurner
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants