Update libsodium to 1.0.18-p0 #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like CI was not able to build - can you double check on it? |
|
@grahamreeds could you update to the provided url/sha1 #634 (comment) |
NeroBurner
reviewed
Jun 2, 2025
cpp-pm#634: Added version 1.0.18 of libsodium to hunter.cmake
NeroBurner
force-pushed
the
pr.hunter_libsodium_1_0_18
branch
from
c9e529c to
8136748
Compare
|
rebased on current master for latest CI toolchains |
NeroBurner
reviewed
Jun 2, 2025
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
I updated the URL/SHA1 but not the version. fixing now
NeroBurner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version 1.0.18-p0 of libsodium to hunter.cmake
I've followed this guide
step by step carefully. [Yes]
I've checked this Git style guide. [No]
I've checked this CMake style guide. [No]
My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes]
I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]
Fixes: #634