fix: don't produce warnings for symbols copied from base classes #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizvekov
changed the title
Collaborator
alandefreitas
left a comment
alandefreitas
left a comment
There was a problem hiding this comment.
Good work exploring this issue. 😃
The warning issue and issue where symbols in the global namespace are extracted both very merit. 👍
Let's be careful about the contract of inherit-base-members and the golden-tests in config that broke. 😅
mizvekov
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1120 +/- ##
===============================
===============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 15, 2025
…ed classes (cppalliance#1120)" This reverts commit c406d57.
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 15, 2025
This reverts commit c3dbded. Revert "build: slim llvm build" This reverts commit 34ea190. Revert "ci(danger): better markdown format" This reverts commit 57e191e. Revert "ci(danger): split PR target ci workflows" This reverts commit 240921d. Revert "ci(danger): align report table and add top-files summary" This reverts commit 5429b2e. Revert "fix(ast): canonicalize friend targets" This reverts commit 76b7b43. Revert "build(bootstrap): modularize recipes" This reverts commit 0d4a845. Revert "chore: assign categories to regression tests" This reverts commit 681b0cd. Revert "fix: manual description comes before member lists" This reverts commit 92491de. Revert "feat: custom stylesheets" This reverts commit 5fe30c1. Revert "docs: split contribute.adoc guide" This reverts commit 302f0a6. Revert "test: support multipage golden tests" This reverts commit bf78b1b. Revert "test: run_ci_with_act.py script" This reverts commit 8326417. Revert "test: testClang_stdCxx default is C++26" This reverts commit 5527e9c. Revert "test: output normalization" This reverts commit d7ad1ce. Revert "test: --bad is disabled by default" This reverts commit 0dfdb22. Revert "test: check int tests results in ctest" This reverts commit ccd7f71. Revert "build: remove CMakeUserPresets.json.example" This reverts commit b2e4bad. Revert "ci: setup danger.js" This reverts commit 6f5f6e9. Revert "fix: preserve extraction mode when copying members from derived classes (cppalliance#1120)" This reverts commit c406d57. Revert "build: typos in the bootstrap script" This reverts commit 2463633. Revert "ci(cpp-matrix): remove the optimized-debug factor" This reverts commit adb6821. Revert "docs(reference): mrdocs comments" This reverts commit b103cba. Revert "feat(util): run_all_tests script" This reverts commit 9b7ec24. Revert "docs: update packages" This reverts commit 5902699. Revert "fix(metadata): copy impl-defined base docs" This reverts commit 05f5852. Revert "ci: gitignore CI node_modules" This reverts commit fdff573. Revert "feat(generators): tables for symbols have headers" This reverts commit 788c1ba. Revert "docs: remove gradients, use solid background, and clean up styles (cppalliance#1101)" This reverts commit 86ce271. Revert "chore: version is 0.8.0" This reverts commit 33d985c. Revert "fix: UsingSymbol is SymbolParent" This reverts commit 36cd25a. Revert "chore: version is 0.0.5" This reverts commit 6b0206c. Revert "getSFINAEControlParams fix" This reverts commit 3948a8c. Revert "fix: minor UI styling improvements (cppalliance#1050)" This reverts commit cf169e6. Revert "fix(docs): update Open Graph and Twitter meta tags for improved sharing (cppalliance#1075)" This reverts commit 5a9b1d2. Revert "fix(ci): setup C++ when building releases (cppalliance#1041)" This reverts commit 13e9230. Revert "Fix support for clang cl-mode driver (cppalliance#1069)" This reverts commit 5e16e3f. Revert "ci: treat warnings as errors" This reverts commit ba0dcfd. Revert "refactor(lib): lua is external dependency" This reverts commit 7715528. Revert "feat(metadata): support recursive inline elements in documentation" This reverts commit 51e2b65. Revert "test(javadoc): refs to parent contexts" This reverts commit 8f98077. Revert "refactor(lib): consistent metadata class family hierarchy pattern" This reverts commit 6d49549. Revert "feat(lib): all base classes implement node kind inc pattern" This reverts commit 1fed5e5. Revert "refactor: nullable_traits null() is only used as implementation detail" This reverts commit ba7f6e5. Revert "refactor(Corpus): valueless_after_move is asserted" This reverts commit 6ba8ef6. Revert "refactor(Corpus): enforce non-optional polymorphic types" This reverts commit afa558a. Revert "feat(Corpus): render source line and caret in warning output" This reverts commit c3d8145. Revert "feat(Corpus): location objects include column number" This reverts commit c7219fa. Revert "fix(Report): do not attempt to format logs without parameters" This reverts commit c8816a5. Revert "feat(lib): expected references" This reverts commit 1da73f8. Revert "feat(lib): optional references" This reverts commit 8ef3ffa. Revert "refactor(lib): Info contains SourceInfo as composition" This reverts commit 948e269. Revert "refactor(lib): use mrdocs::Optional in public API" This reverts commit bd3e121. Revert "feat: show-enum-constants option" This reverts commit 07b69e1. Revert "style: version printer mimics clang" This reverts commit d947525. Revert "refactor: metadata base classes do not expose constructors" This reverts commit 8834acb. Revert "refactor: split base and derived classes" This reverts commit f3d43cb. Revert "build: bootstrap enables libcxx hardening mode" This reverts commit f48bbd2. Revert "docs(contribute): style guide" This reverts commit 08b5707. Revert "refactor(lib): polymorphic is value-type" This reverts commit 479d1e7. Revert "feat(lib): optional nullable traits" This reverts commit c9f9ba1.
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 16, 2025
This reverts commit c3dbded. Revert "build: slim llvm build" This reverts commit 34ea190. Revert "ci(danger): better markdown format" This reverts commit 57e191e. Revert "ci(danger): split PR target ci workflows" This reverts commit 240921d. Revert "ci(danger): align report table and add top-files summary" This reverts commit 5429b2e. Revert "fix(ast): canonicalize friend targets" This reverts commit 76b7b43. Revert "build(bootstrap): modularize recipes" This reverts commit 0d4a845. Revert "chore: assign categories to regression tests" This reverts commit 681b0cd. Revert "fix: manual description comes before member lists" This reverts commit 92491de. Revert "feat: custom stylesheets" This reverts commit 5fe30c1. Revert "docs: split contribute.adoc guide" This reverts commit 302f0a6. Revert "test: support multipage golden tests" This reverts commit bf78b1b. Revert "test: run_ci_with_act.py script" This reverts commit 8326417. Revert "test: testClang_stdCxx default is C++26" This reverts commit 5527e9c. Revert "test: output normalization" This reverts commit d7ad1ce. Revert "test: --bad is disabled by default" This reverts commit 0dfdb22. Revert "test: check int tests results in ctest" This reverts commit ccd7f71. Revert "build: remove CMakeUserPresets.json.example" This reverts commit b2e4bad. Revert "ci: setup danger.js" This reverts commit 6f5f6e9. Revert "fix: preserve extraction mode when copying members from derived classes (cppalliance#1120)" This reverts commit c406d57. Revert "build: typos in the bootstrap script" This reverts commit 2463633. Revert "ci(cpp-matrix): remove the optimized-debug factor" This reverts commit adb6821. Revert "docs(reference): mrdocs comments" This reverts commit b103cba. Revert "feat(util): run_all_tests script" This reverts commit 9b7ec24. Revert "docs: update packages" This reverts commit 5902699. Revert "fix(metadata): copy impl-defined base docs" This reverts commit 05f5852. Revert "ci: gitignore CI node_modules" This reverts commit fdff573. Revert "feat(generators): tables for symbols have headers" This reverts commit 788c1ba. Revert "docs: remove gradients, use solid background, and clean up styles (cppalliance#1101)" This reverts commit 86ce271. Revert "chore: version is 0.8.0" This reverts commit 33d985c. Revert "fix: UsingSymbol is SymbolParent" This reverts commit 36cd25a.
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 16, 2025
This reverts commit c3dbded. Revert "build: slim llvm build" This reverts commit 34ea190. Revert "ci(danger): better markdown format" This reverts commit 57e191e. Revert "ci(danger): split PR target ci workflows" This reverts commit 240921d. Revert "ci(danger): align report table and add top-files summary" This reverts commit 5429b2e. Revert "fix(ast): canonicalize friend targets" This reverts commit 76b7b43. Revert "build(bootstrap): modularize recipes" This reverts commit 0d4a845. Revert "chore: assign categories to regression tests" This reverts commit 681b0cd. Revert "fix: manual description comes before member lists" This reverts commit 92491de. Revert "feat: custom stylesheets" This reverts commit 5fe30c1. Revert "docs: split contribute.adoc guide" This reverts commit 302f0a6. Revert "test: support multipage golden tests" This reverts commit bf78b1b. Revert "test: run_ci_with_act.py script" This reverts commit 8326417. Revert "test: testClang_stdCxx default is C++26" This reverts commit 5527e9c. Revert "test: output normalization" This reverts commit d7ad1ce. Revert "test: --bad is disabled by default" This reverts commit 0dfdb22. Revert "test: check int tests results in ctest" This reverts commit ccd7f71. Revert "build: remove CMakeUserPresets.json.example" This reverts commit b2e4bad. Revert "ci: setup danger.js" This reverts commit 6f5f6e9. Revert "fix: preserve extraction mode when copying members from derived classes (cppalliance#1120)" This reverts commit c406d57. Revert "build: typos in the bootstrap script" This reverts commit 2463633. Revert "ci(cpp-matrix): remove the optimized-debug factor" This reverts commit adb6821. Revert "docs(reference): mrdocs comments" This reverts commit b103cba. Revert "feat(util): run_all_tests script" This reverts commit 9b7ec24.
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 16, 2025
This reverts commit c3dbded. Revert "build: slim llvm build" This reverts commit 34ea190. Revert "ci(danger): better markdown format" This reverts commit 57e191e. Revert "ci(danger): split PR target ci workflows" This reverts commit 240921d. Revert "ci(danger): align report table and add top-files summary" This reverts commit 5429b2e. Revert "fix(ast): canonicalize friend targets" This reverts commit 76b7b43. Revert "build(bootstrap): modularize recipes" This reverts commit 0d4a845. Revert "chore: assign categories to regression tests" This reverts commit 681b0cd. Revert "fix: manual description comes before member lists" This reverts commit 92491de. Revert "feat: custom stylesheets" This reverts commit 5fe30c1. Revert "docs: split contribute.adoc guide" This reverts commit 302f0a6. Revert "test: support multipage golden tests" This reverts commit bf78b1b. Revert "test: run_ci_with_act.py script" This reverts commit 8326417. Revert "test: testClang_stdCxx default is C++26" This reverts commit 5527e9c. Revert "test: output normalization" This reverts commit d7ad1ce. Revert "test: --bad is disabled by default" This reverts commit 0dfdb22. Revert "test: check int tests results in ctest" This reverts commit ccd7f71. Revert "build: remove CMakeUserPresets.json.example" This reverts commit b2e4bad. Revert "ci: setup danger.js" This reverts commit 6f5f6e9. Revert "fix: preserve extraction mode when copying members from derived classes (cppalliance#1120)" This reverts commit c406d57.
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 16, 2025
This reverts commit c3dbded. Revert "build: slim llvm build" This reverts commit 34ea190. Revert "ci(danger): better markdown format" This reverts commit 57e191e. Revert "ci(danger): split PR target ci workflows" This reverts commit 240921d. Revert "ci(danger): align report table and add top-files summary" This reverts commit 5429b2e. Revert "fix(ast): canonicalize friend targets" This reverts commit 76b7b43. Revert "build(bootstrap): modularize recipes" This reverts commit 0d4a845. Revert "chore: assign categories to regression tests" This reverts commit 681b0cd. Revert "fix: manual description comes before member lists" This reverts commit 92491de. Revert "feat: custom stylesheets" This reverts commit 5fe30c1. Revert "docs: split contribute.adoc guide" This reverts commit 302f0a6. Revert "test: support multipage golden tests" This reverts commit bf78b1b. Revert "test: run_ci_with_act.py script" This reverts commit 8326417. Revert "test: testClang_stdCxx default is C++26" This reverts commit 5527e9c. Revert "test: output normalization" This reverts commit d7ad1ce. Revert "test: --bad is disabled by default" This reverts commit 0dfdb22. Revert "test: check int tests results in ctest" This reverts commit ccd7f71. Revert "build: remove CMakeUserPresets.json.example" This reverts commit b2e4bad. Revert "ci: setup danger.js" This reverts commit 6f5f6e9. Revert "fix: preserve extraction mode when copying members from derived classes (cppalliance#1120)" This reverts commit c406d57. Revert "build: typos in the bootstrap script" This reverts commit 2463633. Revert "ci(cpp-matrix): remove the optimized-debug factor" This reverts commit adb6821.
mizvekov
added a commit
to mizvekov/mrdocs
that referenced
this pull request
Dec 16, 2025
This reverts commit c3dbded. Revert "build: slim llvm build" This reverts commit 34ea190. Revert "ci(danger): better markdown format" This reverts commit 57e191e. Revert "ci(danger): split PR target ci workflows" This reverts commit 240921d. Revert "ci(danger): align report table and add top-files summary" This reverts commit 5429b2e. Revert "fix(ast): canonicalize friend targets" This reverts commit 76b7b43. Revert "build(bootstrap): modularize recipes" This reverts commit 0d4a845. Revert "chore: assign categories to regression tests" This reverts commit 681b0cd. Revert "fix: manual description comes before member lists" This reverts commit 92491de. Revert "feat: custom stylesheets" This reverts commit 5fe30c1. Revert "docs: split contribute.adoc guide" This reverts commit 302f0a6. Revert "test: support multipage golden tests" This reverts commit bf78b1b. Revert "test: run_ci_with_act.py script" This reverts commit 8326417. Revert "test: testClang_stdCxx default is C++26" This reverts commit 5527e9c. Revert "test: output normalization" This reverts commit d7ad1ce. Revert "test: --bad is disabled by default" This reverts commit 0dfdb22. Revert "test: check int tests results in ctest" This reverts commit ccd7f71. Revert "build: remove CMakeUserPresets.json.example" This reverts commit b2e4bad. Revert "ci: setup danger.js" This reverts commit 6f5f6e9. Revert "fix: preserve extraction mode when copying members from derived classes (cppalliance#1120)" This reverts commit c406d57. Revert "build: typos in the bootstrap script" This reverts commit 2463633. Revert "ci(cpp-matrix): remove the optimized-debug factor" This reverts commit adb6821. Revert "docs(reference): mrdocs comments" This reverts commit b103cba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1119