Skip to content

Fix #8619 FN memset on container containing structs with containers #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbitcowboy merged 10 commits into from
Sep 21, 2022
Merged

Fix #8619 FN memset on container containing structs with containers #4491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
abe6968
Fix #1655 wrong usage of std::string in memcpy
chrchr-github Sep 12, 2022
b0940ad
Merge branch 'danmar:main' into chr_Fix1655
chrchr-github Sep 13, 2022
12fe3de
Fix memsetClass FP
chrchr-github Sep 15, 2022
f5eb619
Merge
chrchr-github Sep 15, 2022
7f3a844
Merge branch 'chr_Fix1655' of https://github.com/chrchr-github/cppche…
chrchr-github Sep 15, 2022
83f7c73
Fix #8619 FN memset on container containing structs with containers
chrchr-github Sep 21, 2022
efad42c
Merge branch 'main' into chr_Fix1655
chrchr-github Sep 21, 2022
5566aa3
Token::Match
chrchr-github Sep 21, 2022
1cecc0c
Use AST
chrchr-github Sep 21, 2022
657810d
simpleMatch
chrchr-github Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,14 +1319,21 @@ void CheckClass::checkMemset()

const Token *typeTok = nullptr;
const Scope *type = nullptr;
if (Token::Match(arg3, "sizeof ( %type% ) )"))
typeTok = arg3->tokAt(2);
else if (Token::Match(arg3, "sizeof ( %type% :: %type% ) )"))
typeTok = arg3->tokAt(4);
else if (Token::Match(arg3, "sizeof ( struct %type% ) )"))
typeTok = arg3->tokAt(3);
else if (Token::simpleMatch(arg3, "sizeof ( * this ) )") || Token::simpleMatch(arg1, "this ,")) {
type = findFunctionOf(arg3->scope());
const Token* sizeofTok = arg3->previous()->astOperand2(); // try to find sizeof() in argument expression
if (sizeofTok && sizeofTok->astOperand1() && Token::simpleMatch(sizeofTok->astOperand1()->previous(), "sizeof ("))
sizeofTok = sizeofTok->astOperand1();
else if (sizeofTok && sizeofTok->astOperand2() && Token::simpleMatch(sizeofTok->astOperand2()->previous(), "sizeof ("))
sizeofTok = sizeofTok->astOperand2();
if (Token::simpleMatch(sizeofTok, "("))
sizeofTok = sizeofTok->previous();
if (Token::Match(sizeofTok, "sizeof ( %type% )"))
typeTok = sizeofTok->tokAt(2);
else if (Token::Match(sizeofTok, "sizeof ( %type% :: %type% )"))
typeTok = sizeofTok->tokAt(4);
else if (Token::Match(sizeofTok, "sizeof ( struct %type% )"))
typeTok = sizeofTok->tokAt(3);
else if (Token::simpleMatch(sizeofTok, "sizeof ( * this )") || Token::simpleMatch(arg1, "this ,")) {
type = findFunctionOf(sizeofTok->scope());
} else if (Token::Match(arg1, "&|*|%var%")) {
int numIndirToVariableType = 0; // Offset to the actual type in terms of dereference/addressof
for (;; arg1 = arg1->next()) {
Expand Down
15 changes: 15 additions & 0 deletions test/testclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3109,6 +3109,21 @@ class TestClass : public TestFixture {
"}");
ASSERT_EQUALS("", errout.str());

// #8619
checkNoMemset("struct S { std::vector<int> m; };\n"
"void f() {\n"
" std::vector<S> v(5);\n"
" memset(&v[0], 0, sizeof(S) * v.size());\n"
" memset(&v[0], 0, v.size() * sizeof(S));\n"
" memset(&v[0], 0, 5 * sizeof(S));\n"
" memset(&v[0], 0, sizeof(S) * 5);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Using 'memset' on struct that contains a 'std::vector'.\n"
"[test.cpp:5]: (error) Using 'memset' on struct that contains a 'std::vector'.\n"
"[test.cpp:6]: (error) Using 'memset' on struct that contains a 'std::vector'.\n"
"[test.cpp:7]: (error) Using 'memset' on struct that contains a 'std::vector'.\n",
errout.str());

// #1655
Settings s;
LOAD_LIB_2(s.library, "std.cfg");
Expand Down