Skip to content

Fix FP with std::array #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbitcowboy merged 13 commits into from
Sep 23, 2022
Merged

Fix FP with std::array #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
abe6968
Fix #1655 wrong usage of std::string in memcpy
chrchr-github Sep 12, 2022
b0940ad
Merge branch 'danmar:main' into chr_Fix1655
chrchr-github Sep 13, 2022
12fe3de
Fix memsetClass FP
chrchr-github Sep 15, 2022
f5eb619
Merge
chrchr-github Sep 15, 2022
7f3a844
Merge branch 'chr_Fix1655' of https://github.com/chrchr-github/cppche…
chrchr-github Sep 15, 2022
83f7c73
Fix #8619 FN memset on container containing structs with containers
chrchr-github Sep 21, 2022
efad42c
Merge branch 'main' into chr_Fix1655
chrchr-github Sep 21, 2022
5566aa3
Token::Match
chrchr-github Sep 21, 2022
1cecc0c
Use AST
chrchr-github Sep 21, 2022
657810d
simpleMatch
chrchr-github Sep 21, 2022
60725ff
Fix FP with std::array
chrchr-github Sep 23, 2022
f2fd5d4
Merge branch 'main' into chr_Fix1655
chrchr-github Sep 23, 2022
afe71a0
simpleMatch
chrchr-github Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,8 @@ void CheckClass::checkMemset()
if (numIndirToVariableType == 1)
type = var->typeScope();

if (!type && !var->isPointer() && mSettings->library.detectContainerOrIterator(var->typeStartToken())) {
if (!type && !var->isPointer() && !Token::simpleMatch(var->typeStartToken(), "std :: array") &&
mSettings->library.detectContainerOrIterator(var->typeStartToken())) {
memsetError(tok, tok->str(), var->getTypeName(), {}, /*isContainer*/ true);
}
}
Expand Down
6 changes: 6 additions & 0 deletions test/testclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3145,6 +3145,12 @@ class TestClass : public TestFixture {
" f<P>(Dst, Src, 2);\n"
"}\n", s);
ASSERT_EQUALS("", errout.str());

checkNoMemset("void f() {\n"
" std::array<char, 4> a;\n"
" std::memset(&a, 0, 4);\n"
"}\n", s);
ASSERT_EQUALS("", errout.str());
}

void memsetOnInvalid() { // Ticket #5425
Expand Down