removed unnecessary Settings parameter from Check::runChecks() and made Tokenizer a reference#5308
Merged
Merged
Conversation
…d made `Tokenizer` a reference
Collaborator
Author
|
The signature matched the constructor of the checks which might be created without a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no need for the
Tokenizerparameter to be a pointer as it could never benullptrand was also dereferenced without checking first.As a reference to the
Settingswas already available via theTokenizerthere was no need to pass it separately. In the production code there will only be one instance of it but in the tests we could have accidentally passed a different one.