utils.h: added startsWith() and started using it#5381
Merged
Conversation
firewave
changed the title
startsWith() and use itstartsWith() and started using it
danmar
reviewed
Aug 31, 2023
Collaborator
Author
|
Causes a minuscule performance regression (~4m instructions in the callgrind selfcheck in the CI) but still want to check it out first. |
Collaborator
Author
It is actually the other way around. I accidentally switched the output files... |
… was never executed because of broken condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the code much more readable. It also makes it less prone to errors because we do not need to specify the length of the string to match and the returnvalue is clear.
The code with the bad returnvalue check was never executed and I added a test to show that.