Skip to content

Fix #13268 FP: unusedFunction: [[maybe_unused]] #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firewave merged 3 commits into from
Oct 26, 2024
Merged

Fix #13268 FP: unusedFunction: [[maybe_unused]] #6954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8cc8b1
Fix #13268 FP: unusedFunction: [[maybe_unused]]
chrchr-github Oct 26, 2024
9679425
Check isAttributeUnused()
chrchr-github Oct 26, 2024
33449ad
Fix
chrchr-github Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/checkunusedfunctions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ void CheckUnusedFunctions::parseTokens(const Tokenizer &tokenizer, const Setting

FunctionUsage &usage = mFunctions[stripTemplateParameters(func->name())];

if (func->retDef && (func->retDef->isAttributeUnused() || func->retDef->isAttributeMaybeUnused())) {
usage.usedOtherFile = true;
}

if (!usage.lineNumber)
usage.lineNumber = func->token->linenr();

Expand Down
4 changes: 4 additions & 0 deletions test/testunusedfunctions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,10 @@ class TestUnusedFunctions : public TestFixture {
// #10661
check("extern \"C\" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t dataSize) { return 0; }\n");
ASSERT_EQUALS("", errout_str());

check("[[maybe_unused]] void f() {}\n" // #13268
"__attribute__((unused)) void g() {}\n");
ASSERT_EQUALS("", errout_str());
}

void initializer_list() {
Expand Down