Skip to content

fixed #13793 - added CLI option --{no-}analyze-all-vs-configs#7480

Merged
firewave merged 2 commits intocppcheck-opensource:mainfrom
firewave:analyze-vs-all-x
May 6, 2025
Merged

fixed #13793 - added CLI option --{no-}analyze-all-vs-configs#7480
firewave merged 2 commits intocppcheck-opensource:mainfrom
firewave:analyze-vs-all-x

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

One of the prerequisites for #7293.

Comment thread cli/cmdlineparser.cpp
return Result::Fail;
}

// TODO: conflicts with analyzeAllVsConfigs
Copy link
Copy Markdown
Collaborator Author

@firewave firewave Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have like four different ways to select a Visual Studio configuration from the GUI and CLI. At least the code doing it should be unified (if possible). But something for later after the import/CLI handling has been cleaned up and has better test coverage.

Copy link
Copy Markdown
Collaborator

@danmar danmar May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have like four different ways to select a Visual Studio configuration from the GUI and CLI.

ouch

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so as far as I see this will not be an "official" option to start with.. i.e. not shown in the --help output.. which will make it easier to unify later.

Comment thread lib/importproject.cpp
Comment thread cli/cmdlineparser.cpp
return Result::Fail;
}

// TODO: conflicts with analyzeAllVsConfigs
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so as far as I see this will not be an "official" option to start with.. i.e. not shown in the --help output.. which will make it easier to unify later.

@firewave firewave merged commit 3d59c29 into cppcheck-opensource:main May 6, 2025
53 checks passed
@firewave firewave deleted the analyze-vs-all-x branch May 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants