Skip to content

fix #33 show critical warnings with location other than checked file #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidramnero merged 4 commits into from
Dec 13, 2025
Merged

fix #33 show critical warnings with location other than checked file #34

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3aff7b3
fix #33 show critical warnings with location other than checked file
davidramnero Dec 13, 2025
4a42638
pass by checks on line numbers etc if error is critical
davidramnero Dec 13, 2025
f35f4c6
restore removed white space
davidramnero Dec 13, 2025
fbef608
restore another white space
davidramnero Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,23 @@ enum SeverityNumber {
Error = 2
}

const criticalWarningTypes = [
'cppcheckError',
'cppcheckLimit',
'includeNestedTooDeeply',
'internalAstError',
'instantiationError',
'internalError',
'missingFile',
'premium-internalError',
'premium-invalidArgument',
'premium-invalidLicense',
'preprocessorErrorDirective',
'syntaxError',
'unhandledChar',
'unknownMacro'
];

function parseSeverity(str: string): vscode.DiagnosticSeverity {
const lower = str.toLowerCase();
if (lower.includes("error")) {
Expand Down Expand Up @@ -251,23 +268,28 @@ async function runCppcheckOnFileXML(
const diagnostics: vscode.Diagnostic[] = [];

for (const e of errors) {
const isCriticalError = criticalWarningTypes.includes(e.$.id);
const locations = e.location || [];
if (!locations.length) {
continue;
}

const mainLoc = locations[locations.length - 1].$;

// If main location is not current file, then skip displaying warning
if (!filePath.endsWith(mainLoc.file)) {
// If main location is not current file, then skip displaying warning unless it is critical
if (!isCriticalError && !filePath.endsWith(mainLoc.file)) {
continue;
}

// Cppcheck line number is 1-indexed, while VS Code uses 0-indexing
const line = Number(mainLoc.line) - 1;
let line = Number(mainLoc.line) - 1;
// Invalid line number usually means non-analysis output
if (isNaN(line) || line < 0 || line >= document.lineCount) {
continue;
if (isCriticalError) {
line = 0;
} else {
continue;
}
}

// Cppcheck col number is 1-indexed, while VS Code uses 0-indexing
Expand All @@ -277,7 +299,7 @@ async function runCppcheckOnFileXML(
}

const severity = parseSeverity(e.$.severity);
if (severityToNumber(severity) < minSevNum) {
if (!isCriticalError && severityToNumber(severity) < minSevNum) {
continue;
}

Expand Down