Closed
Conversation
czertyaka
reviewed
Oct 11, 2025
Collaborator
czertyaka
left a comment
czertyaka
left a comment
There was a problem hiding this comment.
В целом все хорошо, замечания минорные, задание принято.
Но на всякий случай: PR вливать не надо
| } | ||
|
|
||
| int main() { | ||
| srand(unsigned(time(0))); |
Collaborator
There was a problem hiding this comment.
Приведение выполнится неявно автоматически. От приведения в стиле C особо ничего не изменится, разве что преобразование теперь перед глазами)
| int main() { | ||
| srand(unsigned(time(0))); | ||
|
|
||
| auto number = rand() % 10; |
Collaborator
There was a problem hiding this comment.
Если переменную можно сделать константой — так лучше и поступить
| #define PRINT(text) std::cout << text << std::endl | ||
|
|
||
| int read_user_number() { | ||
| int result; |
Collaborator
There was a problem hiding this comment.
Запись в неинициализированную переменную, строго говоря, не UB. Но вообще в реальных кодовых базах чаще стараются все же инициализировать все переменные: int result {};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.