Кутузова Анна Александровна Фт-320010#43
Open
kutuzova-ann wants to merge 2 commits intocppdevcourse:masterfrom
Open
Кутузова Анна Александровна Фт-320010#43kutuzova-ann wants to merge 2 commits intocppdevcourse:masterfrom
kutuzova-ann wants to merge 2 commits intocppdevcourse:masterfrom
Conversation
added src/two-sum.cpp
added src/two-sum.cpp
czertyaka
requested changes
May 19, 2025
Collaborator
czertyaka
left a comment
There was a problem hiding this comment.
Склонировал проект, переименовал файл srctwo-sum.cpp -> src/two-sum.cpp, тест прошел. Задание можете считать принятым, исправление на ваше усмотрение)
Collaborator
There was a problem hiding this comment.
Файл назван srctwo-sum.cpp, а не two-sum.cpp. И находится в корневой директории проекта, а не в src/. Из-за этого не собираются тесты
Как поправить:
$ git mv srctwo-sum.cpp src/two-sum.cpp
$ git commit -m "moved file"
$ git push| const int target, | ||
| std::size_t& index0, | ||
| std::size_t& index1 | ||
| ) |
Collaborator
There was a problem hiding this comment.
С самим кодом все хорошо, но надо соблюдать последовательность в стиле)
Между сигнатурой функции и телом обычно не ставят новую строку, пробелы в for между выражениями где-то поставлены, а где-то нет
Для домашнего задания в университете совсем не критично, но в реальных проектах обычно за этим следят
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Кутузова А.А. Фт-320010
added src/two-sum.cpp