#68 の修正案 #127
Merged
#68 の修正案 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumetodo
reviewed
Jun 21, 2022
yumetodo
approved these changes
Jun 23, 2022
nyaocat
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68 の修正案です。
このバグは、タイトルが同じ記事が存在するとき（「機能テストマクロ」、「更新された定義済みマクロ」など）、
IndexIdが共通になるためindexElemsに最終的に登録されるのが一番古い記事のものとなり、記事を開いたときにサイドバーでcurrent-pageに設定されるのが同じタイトルの記事のうち一番古いものになる、というものです。とりあえず、タイトルの同じ記事が存在するときだけ、
current-pageに設定する<li>要素を DOM から直接探してindexElemsを上書きしてしまう、というすごくゴリ押しな解決策はいかかでしょうか。