Adjust the Terminal stubs to support MacOS #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All good |
The existing POSIX stubs should be fine. (Tested to work on 11.2.3)
Owner
Author
|
Thanks. Will cut a 0.2.1 shortly. |
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Jun 29, 2021
CHANGES: - Fix the count segment of `Progress.counter` (when `pp` is passed) to show the running total rather than the latest reported value. (craigfe/progress#19; @craigfe, report by @Ngoguey42) - Fix `Terminal` stubs on MacOS. (craigfe/progress#13; @craigfe, report by @Ngoguey42) - Fix package tests on Windows. `Progress` does not yet support the Windows and Cygwin terminals; this is tracked by craigfe/progress#16. (craigfe/progress#15; @emillon)
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Jun 29, 2021
CHANGES: - Fix the count segment of `Progress.counter` (when `pp` is passed) to show the running total rather than the latest reported value. (craigfe/progress#19; @craigfe, report by @Ngoguey42) - Fix `Terminal` stubs on MacOS. (craigfe/progress#13; @craigfe, report by @Ngoguey42) - Fix package tests on Windows. `Progress` does not yet support the Windows and Cygwin terminals; this is tracked by craigfe/progress#16. (craigfe/progress#15; @emillon)
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Jun 29, 2021
CHANGES: - Fix the count segment of `Progress.counter` (when `pp` is passed) to show the running total rather than the latest reported value. (craigfe/progress#19; @craigfe, report by @Ngoguey42) - Fix `Terminal` stubs on MacOS. (craigfe/progress#13; @craigfe, report by @Ngoguey42) - Fix package tests on Windows. `Progress` does not yet support the Windows and Cygwin terminals; this is tracked by craigfe/progress#16. (craigfe/progress#15; @emillon)
craigfe
added a commit
to craigfe/alcotest
that referenced
this pull request
Oct 8, 2021
craigfe
added a commit
to mirage/alcotest
that referenced
this pull request
Oct 8, 2021
* Fix bindings to `TIOCGWINSZ` on MacOS See craigfe/progress#13. * Add a CHANGES entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing POSIX stubs should be fine. (Tested to work on 11.2.3.)
Fixes #12. CC @Ngoguey42: when you get time, can you check these work on your machine?