Add pause/resume functions #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
force-pushed
the
pause_resume
branch
from
0d6a485 to
5bddfff
Compare
dinosaure
approved these changes
Feb 2, 2024
Contributor
Author
|
The CI failure seems unrelated to this PR : see the error |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Apr 13, 2024
CHANGES: - Be compatible with MirageOS and remove `ocaml_terminal_get_sigwinch` (@art-w, craigfe/progress#38) - Clear all lines in `interject_with` (@Gbury, craigfe/progress#30) - Add `Display.remove_line` (@mbarbin, craigfe/progress#26) - Fix compilation for OCaml 5.2 (reported by @Gbury, fixed by @dinosaure, craigfe/progress#40) - Add `Display.{pause,resume}` (@Gbury, craigfe/progress#37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pause/resume functions, which are a bit more expressive version of the
interject_withfunction.Without these functions (i.e. only using the
interject_withfunction), it does not seem possible to implement afprintf-like logging function, i.e. a functionlog : Format.formatter -> ('a, Format.formatter, unit) format -> 'athat properly stops rendering of progress bars, does the logging, and then resume printing of the progress bars. The problem part is that such afprintf-like function returns a function that consumes the printing argument.This is based on #30