Skip to content

Better error messages for sample 4 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TaoChenOSU merged 1 commit into from
Mar 16, 2023
Merged

Better error messages for sample 4 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions samples/apps/github-qna-webapp-react/src/components/GitHubRepoSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ const GitHubProjectSelection: FC<IData> = ({ uri, keyConfig, onLoadProject, onBa
);
setIsLoaded(true);
console.log(result);
} catch {
} catch (e) {
setIsLoadError(true);
alert('Something went wrong. Please check that the function is running and accessible from this location.');
alert('Something went wrong.\n\nDetails:\n' + e);
}
};

Expand Down Expand Up @@ -86,7 +86,7 @@ const GitHubProjectSelection: FC<IData> = ({ uri, keyConfig, onLoadProject, onBa
{isLoading ? (
<div>
<Spinner />
<Body1>Downloading respository...</Body1>
<Body1>Downloading repository...</Body1>
</div>
) : (
<></>
Expand Down
4 changes: 2 additions & 2 deletions samples/apps/github-qna-webapp-react/src/components/ServiceConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ const ServiceConfig: FC<IData> = ({ uri, onConfigComplete }) => {
console.log(result);
onConfigComplete(keyConfig);
}
catch {
alert('Something went wrong, please check you have the function running and that it is accessible by the web app');
catch (e) {
alert('Something went wrong.\n\nDetails:\n' + e);
}

setIsBusy(false);
Expand Down