Fix for 'all connections are in use' when calling read.markup.RCC() on multiple files.#1
Open
chrisrgc wants to merge 1 commit intocran:masterfrom
Open
Fix for 'all connections are in use' when calling read.markup.RCC() on multiple files.#1chrisrgc wants to merge 1 commit intocran:masterfrom
chrisrgc wants to merge 1 commit intocran:masterfrom
Conversation
…() to avoid exhausting the 125 user allocatable connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package Version: NanoStringNorm 1.2.0
R Version: 3.3.2
OS: Windows 10 x64
When loading a series of 144 raw Nanostring RCC files using
NanoStringNorm::read.markup.RCC(), processing of the 32nd file fails with the error:...when creating the
sample.contextConnection (https://github.com/cran/NanoStringNorm/blob/1.2.0/R/read.markup.RCC.R#L55)help("connections", package="base")states that the maximum number of allocated connections is 128 (with 3 reserved forstdin, stdout, stderr) and I can see thatread.markup.RCC()is opening textConnections but not closing them and hitting the hard limit of 125 usable connections.As each call to
read.markup.RCC()opens 4 connections, all 125 available will be allocated by the time sample.con is created on the 32nd iteration.Simply closing the connection once the data has been read from the file resolves this problem.