Skip to content

Making the server external by default. Because if your computer is fa…#185

Open
yeerkkiller1 wants to merge 1 commit intomasterfrom
cnfg
Open

Making the server external by default. Because if your computer is fa…#185
yeerkkiller1 wants to merge 1 commit intomasterfrom
cnfg

Conversation

@yeerkkiller1
Copy link
Copy Markdown
Collaborator

Lets do this. Maybe we should even set port to 79 (so the http port is 80), but definitely 8079 (as the previous http port was 8080).

…cing the internet, people on your buildblast server is the least of your problems!
@kieve
Copy link
Copy Markdown
Collaborator

kieve commented Oct 14, 2015

We should just define two ports. One for the www site, the other for the game.

@yeerkkiller1
Copy link
Copy Markdown
Collaborator Author

Yeah probably, but we should definitely not change the port from 8080 to 8081.

And the localhost -> "" thing... very useful. That way we don't need to understand why the server works on localhost but not for anyone else, it will just work for everyone that can hit our computer.

@kieve
Copy link
Copy Markdown
Collaborator

kieve commented Oct 14, 2015

We're not changing the port from 8080 to 8081. 8080 is used for the webserver. It just happens that in the dev environment, I'm the only one that runs it. You guys could too. And in the future you'll want to. Bunch of features are going to come from there.

@crazy2be
Copy link
Copy Markdown
Owner

Well but you still have to play the game on 8081, don't you?

@crazy2be
Copy link
Copy Markdown
Owner

Even in the dev environment, I mean.

@kieve
Copy link
Copy Markdown
Collaborator

kieve commented Oct 22, 2015

I fail to see why this is a problem. For someone coming in, entering a port and wondering why they can't play the game on that port, I can see the problem. The solution is not to change the default port to 8079, because that doesn't solve the problem. "Why isn't the game running on 8079?". I am not overly attached to the port 8080, so it doesn't actually matter to me which port it is running on. The correct solution is to have separate port options for the WWW website and the game.

Once I get ahead (caught up) on assignments, I'll update this so that a default game and www port are defined. Then we can all just configure to use what ever we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants