fix: disable Zend Signals and enable Zend Max Execution Timers for ZTS builds#135
Merged
crazywhalecc merged 3 commits intocrazywhalecc:mainfrom Aug 21, 2023
Merged
Conversation
Owner
crazywhalecc
left a comment
There was a problem hiding this comment.
I don't know much about ZTS bugs, but based on the information you provided, we need to disable the zend signal, and there is no better solution.
And --enable-zend-max-execution-timers makes ZTS safer.
Am I right?
Contributor
Author
|
Exactly. |
crazywhalecc
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PHP issues:
The official ZTS Docker images also include these flags.