Initial code to get Box for phar building, replace DeployCommand#175
Merged
crazywhalecc merged 6 commits intocrazywhalecc:mainfrom Sep 13, 2023
Merged
Initial code to get Box for phar building, replace DeployCommand#175crazywhalecc merged 6 commits intocrazywhalecc:mainfrom
crazywhalecc merged 6 commits intocrazywhalecc:mainfrom
Conversation
8e049b0 to
21195ab
Compare
Owner
|
After introducing box, it is a good choice to directly rewrite DeployCommand. Ideally, we can automatically package single executable SPC files for different platforms and upload them when releasing a new version:
|
5 tasks
Contributor
Author
|
@crazywhalecc Extracted this as a roadmap for rewrite: #179 |
a86601f to
a692419
Compare
Owner
|
Are there any positive considerations for using the Version class? |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
@crazywhalecc Removed the version class, Box was able to call the public const in the end. The workflow file was also removed. |
Contributor
Author
|
Failure unrelated requires a job re-run (probably an issue with GH actions). |
crazywhalecc
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info: