Tests for state changes in REST API?

[cfergeau]

minikube has some issues with HardStop kubernetes/minikube#20504 , and I'm not sure we have full test coverage for the REST API

[nirs]

The issue seems to be here:

	errCh := make(chan error, 1)
	go func() {
		if err := waitForVMState(vm, vz.VirtualMachineStateStopped, nil); err != nil {
			errCh <- fmt.Errorf("virtualization error: %v", err)
		} else {
			log.Infof("VM is stopped")
			errCh <- nil
		}
	}()

When the vm stops, we return immediately from runVirtualMachine. This may happens before the client got the response for Post HardStop:

	response := vm.ChangeState(define.StateChange(s.State))
	if response != nil {
		logrus.Errorf("failed action %s: %q", s.State, response)
		c.JSON(http.StatusInternalServerError, gin.H{"error": response.Error()})
		return
	}
	c.Status(http.StatusAccepted)

Maybe when handling a HardStop should synchronize with main(), so main wil wait until the response is written to the client?