fix: added goalCode, outOfBandRecordId, credentialRequestThId in credential controller#235
Merged
pranalidhanavade merged 5 commits intodevelopfrom Feb 21, 2025
Merged
Conversation
…ential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
pranalidhanavade
changed the title
pranalidhanavade
requested review from
ankita-p17,
sairanjit and
tipusinghaw
sairanjit
requested changes
Feb 20, 2025
…controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
|
RinkalBhojani
approved these changes
Feb 21, 2025
pranalidhanavade
added a commit
that referenced
this pull request
Mar 6, 2025
…ential controller (#235) * fix: added goalCode, outOfBandRecordId, credentialRequestThId in credential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added conditions for connectionId and outOfBandId in credential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added optional chaining for connectionId record Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added extra check contextCorrelationId in credential events Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: removed extra check for contextCorrelationId Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
KambleSahil3
pushed a commit
that referenced
this pull request
Apr 30, 2025
…ential controller (#235) * fix: added goalCode, outOfBandRecordId, credentialRequestThId in credential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added conditions for connectionId and outOfBandId in credential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added optional chaining for connectionId record Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added extra check contextCorrelationId in credential events Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: removed extra check for contextCorrelationId Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
KambleSahil3
pushed a commit
that referenced
this pull request
Apr 30, 2025
…ential controller (#235) * fix: added goalCode, outOfBandRecordId, credentialRequestThId in credential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added conditions for connectionId and outOfBandId in credential controller Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added optional chaining for connectionId record Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: added extra check contextCorrelationId in credential events Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: removed extra check for contextCorrelationId Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
outofBandRecordin the credential controller.Why?