refactor: update DID creation response#236
Merged
bhavanakarwade merged 5 commits intodevelopfrom Feb 21, 2025
Merged
Conversation
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
…into refactor/did-create-response-for-polygon
sairanjit
requested changes
Feb 21, 2025
prasadgkalamkar
suggested changes
Feb 21, 2025
prasadgkalamkar
left a comment
prasadgkalamkar
left a comment
There was a problem hiding this comment.
Define the type of the variable.
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
sairanjit
approved these changes
Feb 21, 2025
…into refactor/did-create-response-for-polygon
|
pranalidhanavade
pushed a commit
that referenced
this pull request
Mar 6, 2025
* refactor: create did response Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> * fix: resolved comments Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> * fix: handle validations for polygon Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> --------- Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KambleSahil3
pushed a commit
that referenced
this pull request
Apr 30, 2025
* refactor: create did response Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> * fix: resolved comments Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> * fix: handle validations for polygon Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> --------- Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KambleSahil3
pushed a commit
that referenced
this pull request
Apr 30, 2025
* refactor: create did response Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> * fix: resolved comments Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> * fix: handle validations for polygon Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> --------- Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ?
keyTypeproperty optional in the DID creation functionality, as it is not mandatory for Polygon.