fix: added variables in env sample and env demo files#1493
fix: added variables in env sample and env demo files#1493pranalidhanavade merged 1 commit intomainfrom
Conversation
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
WalkthroughEnvironment variable declarations for AWS resources and load balancer configuration were added to both Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.env.demo (1)
173-177: Reorder variables for alphabetical consistency.The newly added AWS infrastructure variables don't follow alphabetical ordering, which may impact maintainability and consistency with linting standards (dotenv-linter flags this). Consider reordering to: ADMIN_TG_ARN, ECS_SECURITY_GROUP_ID, ECS_SUBNET_ID, FILESYSTEMID, INBOUND_TG_ARN.
Apply this diff to reorder alphabetically:
-ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx -FILESYSTEMID=fs-xxxxxxxx -ECS_SUBNET_ID=subnet-xxxxxxxx -INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> -ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> +ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> +ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx +ECS_SUBNET_ID=subnet-xxxxxxxx +FILESYSTEMID=fs-xxxxxxxx +INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>.env.sample (1)
193-198: Reorder variables for alphabetical consistency and align with .env.demo.Two issues to address:
Ordering inconsistency: The newly added variables don't follow alphabetical ordering (flagged by dotenv-linter 5 times). Alphabetical order should be: ADMIN_TG_ARN, ECS_SECURITY_GROUP_ID, ECS_SUBNET_ID, FILESYSTEMID, INBOUND_TG_ARN, PLATFORM_URL.
File alignment: In
.env.demo,PLATFORM_URLis at line 40 with platform/API configuration, not grouped with AWS infrastructure variables. For consistency across sample files, consider placingPLATFORM_URLseparately per.env.demo's organization.Apply this diff to reorder alphabetically and maintain conceptual grouping:
-PLATFORM_URL=https://devapi.credebl.id -ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx -FILESYSTEMID=fs-xxxxxxxx -ECS_SUBNET_ID=subnet-xxxxxxxx -INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> -ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> +ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> +ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx +ECS_SUBNET_ID=subnet-xxxxxxxx +FILESYSTEMID=fs-xxxxxxxx +INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id> +PLATFORM_URL=https://devapi.credebl.idAlternatively, if
PLATFORM_URLshould be grouped with platform configuration (to align with.env.demo), move it to an earlier section of the file where other platform variables are defined.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.env.demo(1 hunks).env.sample(1 hunks)
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
.env.sample
[warning] 194-194: [UnorderedKey] The ECS_SECURITY_GROUP_ID key should go before the PLATFORM_URL key
(UnorderedKey)
[warning] 195-195: [UnorderedKey] The FILESYSTEMID key should go before the PLATFORM_URL key
(UnorderedKey)
[warning] 196-196: [UnorderedKey] The ECS_SUBNET_ID key should go before the FILESYSTEMID key
(UnorderedKey)
[warning] 197-197: [UnorderedKey] The INBOUND_TG_ARN key should go before the PLATFORM_URL key
(UnorderedKey)
[warning] 198-198: [UnorderedKey] The ADMIN_TG_ARN key should go before the ECS_SECURITY_GROUP_ID key
(UnorderedKey)
.env.demo
[warning] 175-175: [UnorderedKey] The ECS_SUBNET_ID key should go before the FILESYSTEMID key
(UnorderedKey)
[warning] 177-177: [UnorderedKey] The ADMIN_TG_ARN key should go before the ECS_SECURITY_GROUP_ID key
(UnorderedKey)



What
Summary by CodeRabbit