Skip to content

fix: added variables in env sample and env demo files#1493

Merged
pranalidhanavade merged 1 commit intomainfrom
fix/add-variables-in-env-demo-and-sample
Oct 24, 2025
Merged

fix: added variables in env sample and env demo files#1493
pranalidhanavade merged 1 commit intomainfrom
fix/add-variables-in-env-demo-and-sample

Conversation

@pranalidhanavade
Copy link
Copy Markdown
Contributor

@pranalidhanavade pranalidhanavade commented Oct 24, 2025

What

  • fix: added variables in .env.sample and .env.demo files.

Summary by CodeRabbit

  • Chores
    • Added new environment variable configurations for infrastructure deployment and load balancer management.

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 24, 2025

Walkthrough

Environment variable declarations for AWS resources and load balancer configuration were added to both .env.demo and .env.sample files. Five variables were added to .env.demo, and six variables (including PLATFORM_URL) were added to .env.sample, positioned after AGENT_API_KEY.

Changes

Cohort / File(s) Summary
Environment Configuration Files
.env.demo, .env.sample
Added environment variable declarations for AWS ECS security groups, filesystem IDs, subnets, and target group ARNs. .env.sample also includes PLATFORM_URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Five new variables hop into the demo file,
Six into the sample, AWS-style!
ECS and filesystems, all in a line,
Configuration variables, perfectly fine! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix: added variables in env sample and env demo files" directly and accurately describes the main change in the changeset. The PR adds environment variables to both the .env.sample and .env.demo files, which is exactly what the title conveys. The title is specific about which files are affected, clear about the action taken, and directly aligns with the PR objectives. It is neither vague nor misleading, and provides sufficient context for a reviewer scanning the commit history to understand the primary purpose of the change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/add-variables-in-env-demo-and-sample

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.env.demo (1)

173-177: Reorder variables for alphabetical consistency.

The newly added AWS infrastructure variables don't follow alphabetical ordering, which may impact maintainability and consistency with linting standards (dotenv-linter flags this). Consider reordering to: ADMIN_TG_ARN, ECS_SECURITY_GROUP_ID, ECS_SUBNET_ID, FILESYSTEMID, INBOUND_TG_ARN.

Apply this diff to reorder alphabetically:

-ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx
-FILESYSTEMID=fs-xxxxxxxx
-ECS_SUBNET_ID=subnet-xxxxxxxx
-INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
-ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
+ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
+ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx
+ECS_SUBNET_ID=subnet-xxxxxxxx
+FILESYSTEMID=fs-xxxxxxxx
+INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
.env.sample (1)

193-198: Reorder variables for alphabetical consistency and align with .env.demo.

Two issues to address:

  1. Ordering inconsistency: The newly added variables don't follow alphabetical ordering (flagged by dotenv-linter 5 times). Alphabetical order should be: ADMIN_TG_ARN, ECS_SECURITY_GROUP_ID, ECS_SUBNET_ID, FILESYSTEMID, INBOUND_TG_ARN, PLATFORM_URL.

  2. File alignment: In .env.demo, PLATFORM_URL is at line 40 with platform/API configuration, not grouped with AWS infrastructure variables. For consistency across sample files, consider placing PLATFORM_URL separately per .env.demo's organization.

Apply this diff to reorder alphabetically and maintain conceptual grouping:

-PLATFORM_URL=https://devapi.credebl.id
-ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx
-FILESYSTEMID=fs-xxxxxxxx
-ECS_SUBNET_ID=subnet-xxxxxxxx
-INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
-ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
+ADMIN_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
+ECS_SECURITY_GROUP_ID=sg-xxxxxxxxxxxxxxxxx
+ECS_SUBNET_ID=subnet-xxxxxxxx
+FILESYSTEMID=fs-xxxxxxxx
+INBOUND_TG_ARN=arn:aws:elasticloadbalancing:<region>:<account-id>:targetgroup/<name>/<id>
+PLATFORM_URL=https://devapi.credebl.id

Alternatively, if PLATFORM_URL should be grouped with platform configuration (to align with .env.demo), move it to an earlier section of the file where other platform variables are defined.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1b6abf and 60d848d.

📒 Files selected for processing (2)
  • .env.demo (1 hunks)
  • .env.sample (1 hunks)
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
.env.sample

[warning] 194-194: [UnorderedKey] The ECS_SECURITY_GROUP_ID key should go before the PLATFORM_URL key

(UnorderedKey)


[warning] 195-195: [UnorderedKey] The FILESYSTEMID key should go before the PLATFORM_URL key

(UnorderedKey)


[warning] 196-196: [UnorderedKey] The ECS_SUBNET_ID key should go before the FILESYSTEMID key

(UnorderedKey)


[warning] 197-197: [UnorderedKey] The INBOUND_TG_ARN key should go before the PLATFORM_URL key

(UnorderedKey)


[warning] 198-198: [UnorderedKey] The ADMIN_TG_ARN key should go before the ECS_SECURITY_GROUP_ID key

(UnorderedKey)

.env.demo

[warning] 175-175: [UnorderedKey] The ECS_SUBNET_ID key should go before the FILESYSTEMID key

(UnorderedKey)


[warning] 177-177: [UnorderedKey] The ADMIN_TG_ARN key should go before the ECS_SECURITY_GROUP_ID key

(UnorderedKey)

@pranalidhanavade pranalidhanavade merged commit a4d9755 into main Oct 24, 2025
8 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Nov 20, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants