fix: remove dead code before raise in _create_manager_agent#5414
Open
Yanyadua wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: remove dead code before raise in _create_manager_agent#5414Yanyadua wants to merge 1 commit intocrewAIInc:mainfrom
Yanyadua wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
Remove unreachable `manager.tools = []` assignment that is immediately followed by a raise statement, making the assignment dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manager.tools = []assignment in_create_manager_agent()that is immediately followed by araise Exception, making the assignment dead code.Details
In
crew.py, the_create_manager_agentmethod had this code: