fix(devtools): include all workspace packages in bump pin rewrites#5778
Conversation
The bump rewrite logic only knew crewai, crewai-tools, crewai-devtools, so split-package pins (crewai-core, crewai-cli, crewai-files) were left on the previous version after each bump. Adds a regression test that fails if any workspace member is missing from _DEFAULT_WORKSPACE_PACKAGES.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR expands the workspace package list to include ChangesWorkspace Packages Expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/devtools/tests/test_toml_updates.py`:
- Around line 244-246: The test imports tomllib which only exists on Python
3.11+, causing failures on Python 3.10; update the import near where
tomllib.loads is used (in lib/devtools/tests/test_toml_updates.py) to use a
guarded fallback that tries to import tomllib and falls back to tomli (e.g., try
importing tomllib and except ModuleNotFoundError import tomli as tomllib) so
that the call to tomllib.loads and the variable members continue to work on
Python 3.10, or alternatively update the project's requires-python to >=3.11 if
dropping 3.10 support.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6ebacf16-182b-4906-a1dd-6ca937c82430
📒 Files selected for processing (2)
lib/devtools/src/crewai_devtools/cli.pylib/devtools/tests/test_toml_updates.py
Summary
_DEFAULT_WORKSPACE_PACKAGESonly listedcrewai,crewai-tools,crewai-devtools, so version bumps silently leftcrewai-core,crewai-cli, andcrewai-filespins on the previous version. This is what caused the stale1.14.5a4pins inlib/crewai/pyproject.tomlandlib/cli/pyproject.tomlflagged on the 1.14.5a5 bump (Cursor bugbot on a3b3d13).[tool.uv.workspace] membersentry is absent from the rewrite list.Test plan
uv run pytest lib/devtools/tests/test_toml_updates.py— 28 passedlib/crewai/pyproject.tomlnow rewrites all four pins (crewai-core,crewai-cli,crewai-tools,crewai-files)Note
Low Risk
Low risk: changes are limited to devtools version-bump pin rewrites and add regression tests to prevent missing workspace packages; no runtime product logic is affected.
Overview
Fixes
devtoolsversion bumping soupdate_pyproject_dependenciesrewrites pins for all workspace packages by expanding_DEFAULT_WORKSPACE_PACKAGESto includecrewai-cli,crewai-core, andcrewai-files.Adds tests ensuring every
[tool.uv.workspace]member is covered by the default rewrite list, that pins acrossdependenciesandoptional-dependenciesare updated, and thatcrewai==...does not incorrectly collide withcrewai-core==....Reviewed by Cursor Bugbot for commit f575667. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Improvements
Tests