Resolved Merge Conflicts for PR #712: Remove Hyphen in co-workers#786
Merged
Conversation
…tes in the agent name which messed up the string comparison. Added additional types. Cleaned up error messaging.
bhancockio
added a commit
that referenced
this pull request
Jan 2, 2025
* removed hyphen in co-workers * Fix issue with AgentTool agent selection. The LLM included double quotes in the agent name which messed up the string comparison. Added additional types. Cleaned up error messaging. * Remove duplicate import * Improve explanation * Revert poetry.lock changes * Fix missing line in poetry.lock --------- Co-authored-by: madmag77 <goncharov.artemv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the merge conflicts present in the original PR #712 submitted by @madmag77, which aimed to remove the hyphen from "co-worker" to "coworker" in the codebase. This change was necessary to ensure compatibility with open source language models that do not handle hyphens correctly in prompt processing.
Additionally, I fixed a string comparison issue which prevent AgentTools from selecting the appropriate agent. The underlying issue for this issue is that weaker LLM's struggle to produce valid JSON. Quite often, these weaker LLM's truncate the final part of their response. In the case of AgentTools, these weaker LLM's would produce responses like
{"coworker": "reasearcherwhen it should have produced JSON like{"coworker": "reasearcher"}.Original PR Details:
Changes in This PR:
Acknowledgments:
Special thanks to @madmag77 for the initial implementation and efforts to fix the LLM compatibility issue.
References: