-
Notifications
You must be signed in to change notification settings - Fork 3
Update typography styles #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To further align the documentation with the design system. Updates include: - link styles (font color set to primary, no underline) - text color for most elements (including bold text) changed to light-blue-800
✅ Deploy Preview for criipto-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Trinurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
|
@Trinurt @nmoskaleva This reduces accessibility because links are no longer decorated. Is this an intentional choice? |
|
I agree with @fkj here, links should have decoration in text/markdown heavy rendering. |
| '--tw-prose-bold': theme('colors.light-blue.800'), | ||
| a: { | ||
| color: theme('colors.primary.600'), | ||
| textDecoration: 'none', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should still be underline imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also be e.g. bolded (with enough contrast) or have some other decoration that make them stand out without solely relying on colors.
@nmoskaleva We don't formally do accessibility testing on the dashboard yet. We might begin. But also a lot less text there a much less in-text links. |
|
@Trinurt An example with bold + underlined links: |
|
@nmoskaleva Yes, it is a good point. Let's add an underline to the purple colored text - but NOT bold. Regarding the Dashboard it is still a ticket in the backlog to define the inline text link design. |


To further align the documentation with the design system. Updates include:
light-blue-800QA: The new "softer" look and the new link styles are prominent if you open the same page side by side, for instance:
https://docs.idura.app/verify/getting-started/basics/ and https://deploy-preview-276--criipto-docs.netlify.app/verify/getting-started/basics/