#220 - chore(backend): Fix Maintainability Issues - SonarQube#338
Draft
yasminehilout wants to merge 15 commits intodevfrom
Draft
#220 - chore(backend): Fix Maintainability Issues - SonarQube#338yasminehilout wants to merge 15 commits intodevfrom
yasminehilout wants to merge 15 commits intodevfrom
Conversation
…izationProject into 220/chore-backend-maintainability-fix
…ble workspaces path
…by extracting helper methods
… extracting methods for content extraction and asset handling
…nstant in DataController
…ync verification in DataControllerTests
yasminehilout
added
Back End
yasminehilout
commented
Mar 31, 2025
im-samwong
reviewed
Mar 31, 2025
Comment on lines
+35
to
+36
| @Value("${geoserver.workspacesPath}") | ||
| private String geoserverWorkspacesPath; |
Collaborator
There was a problem hiding this comment.
This is an unnecessary change. It is a constant string and will never change, why put it with application properties when it is not.
…izationProject into 220/chore-backend-maintainability-fix
Collaborator
Author
|
This is a draft pull request capturing work in progress during Release 3. It is being documented here for transparency and potential future continuation. As part of the capstone handoff, we are unassigning ourselves from this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses maintainability issues identified by SonarQube in the backend codebase. The goal is to improve code clarity and reduce technical debt without altering functionality.
Changes Made
Testing Instructions
Screenshots (if applicable)
Before:
Now:
Additional Notes
❗️Request for Review:
Left a comment on
DataService.javaline 98 — I’m wondering if that unused progress value is still needed or if we can remove it.🟡 Known SonarCloud Warning:
The
StacDataConverter.javafile still shows some unused code warnings in SonarCloud. This is expected for now, as that file isn’t currently in use but will possibly be integrated in an upcoming iteration.