# 349 - Replaced should be visible with should exist#350
Draft
LiamDaigle wants to merge 2 commits intodevfrom
Draft
# 349 - Replaced should be visible with should exist#350LiamDaigle wants to merge 2 commits intodevfrom
LiamDaigle wants to merge 2 commits intodevfrom
Conversation
Contributor
Author
|
This is a draft pull request capturing work in progress during Release 3. It is being documented here for transparency and potential future continuation. As part of the capstone handoff, we are unassigning ourselves from this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e pipeline was having weird behavior when it came to finding the toastify popups in the tests. The errors would essential tell us that the popups existed, but since they were being blocked by other components they were not visible. So, this PR just simply replaces the .should('be.visible') in the tests with .should('exist') as this check only ensures that it exists in the DOM (not necessarily if its on screen).
Changes Made
Testing Instructions