Merged
Conversation
* Use the v2 import path for installation of the binary. * Update the arguments passed by nvim-go for v2 compatibility.
Owner
|
I think we should compat v1 user or at least tell them to update to v2. Otherwise, they will fail immediately after update. |
Contributor
Author
|
Do you mean that it should detect the golangci-lint version at runtime and throw an error if the user has v1 installed? |
Owner
Yes, this would be more compatible. |
Contributor
Author
|
Does that check improve things? The only problem is that it runs the version check every time you run |
crispgm
reviewed
Apr 8, 2025
crispgm
approved these changes
Apr 8, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #72