Skip to content

Bump golangci-lint to v2#73

Merged
crispgm merged 3 commits intocrispgm:mainfrom
smlx:golangci-lint-v2
Apr 8, 2025
Merged

Bump golangci-lint to v2#73
crispgm merged 3 commits intocrispgm:mainfrom
smlx:golangci-lint-v2

Conversation

@smlx
Copy link
Contributor

@smlx smlx commented Apr 5, 2025

  • Use the v2 import path for installation of the binary.
  • Update the arguments passed by nvim-go for v2 compatibility.

Closes: #72

* Use the v2 import path for installation of the binary.
* Update the arguments passed by nvim-go for v2 compatibility.
@crispgm
Copy link
Owner

crispgm commented Apr 6, 2025

I think we should compat v1 user or at least tell them to update to v2. Otherwise, they will fail immediately after update.

@smlx
Copy link
Contributor Author

smlx commented Apr 7, 2025

Do you mean that it should detect the golangci-lint version at runtime and throw an error if the user has v1 installed?

@crispgm
Copy link
Owner

crispgm commented Apr 7, 2025

Do you mean that it should detect the golangci-lint version at runtime and throw an error if the user has v1 installed?

Yes, this would be more compatible.

@smlx
Copy link
Contributor Author

smlx commented Apr 7, 2025

Does that check improve things? The only problem is that it runs the version check every time you run :GoLint.

@crispgm crispgm merged commit a665d79 into crispgm:main Apr 8, 2025
2 of 5 checks passed
@crispgm
Copy link
Owner

crispgm commented Apr 8, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

golangci-lint needs to be bumped to v2 for GoInstallBinaries

2 participants