Skip to content

Fix throwing with client-supplied invalid cookie #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vrurg wants to merge 1 commit into from
Closed

Fix throwing with client-supplied invalid cookie #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/Cro/HTTP/Request.pm6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,14 @@ class Cro::HTTP::Request does Cro::HTTP::Message {
@str = @str[0].value.split(/';' ' '?/).List;
my @res;
for @str {
CATCH {
when X::TypeCheck::Assignment {
# Skip cookies with invalid name or value. Since they're received from a client we must not die. But
# neither we're obliged to maintain them.
.rethrow unless .symbol eq '$!value' | '$!name';
next
}
}
my ($name, $value) = $_.split('=');
@res.push: Cro::HTTP::Cookie.new(:$name, :$value) if $name;
}
Expand Down