Skip to content

Fix setting expected values in TestSetterAndGetterTrait #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TiSiE merged 2 commits into from
Feb 19, 2020
Merged

Fix setting expected values in TestSetterAndGetterTrait #6

TiSiE merged 2 commits into from
Feb 19, 2020

Conversation

@TiSiE
Copy link
Member

@TiSiE TiSiE commented Feb 19, 2020 •
edited
Loading

Fix #5

  • Creates TestCase for unwanted behaviour.
  • Makes the comparisons strict, so types are not casted automatically.

@TiSiE TiSiE changed the title This will fix #5 Fix setting expected values in TestSetterAndGetterTrait Feb 19, 2020
@TiSiE TiSiE merged commit d02137d into cross-solution:master Feb 19, 2020
TiSiE added a commit that referenced this pull request Feb 19, 2020
@TiSiE
Merge pull request #6: Release 2.0.1
7b061f9 
* pr-6:
  Fix #5: Setting expected values does not work properly
  Create TestCase that reproduce unwanted behaviour
@TiSiE TiSiE deleted the b5-set_expect_value branch February 19, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestSetterAndGetterTrait: Impossible to set expected value if it evaluates to 'true'

1 participant

@TiSiE