Add support for Deletion Sequencing #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobh66
force-pushed
the
create_usages
branch
from
28d2d79 to
12e24a2
Compare
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
negz
approved these changes
Jan 16, 2026
Member
negz
left a comment
negz
left a comment
There was a problem hiding this comment.
I've been thinking about how we might tackle creation/deletion ordering more generally in functions. I don't have a good solution yet, but that doesn't need to block this. I feel okay with this approach in this function.
Note: I'm not a maintainer on this function, and don't have any experience using it. So take this as my informed bystander opinion and not a binding approval.
| } | ||
|
|
||
| // GenerateUsage determines whether to return a v1 or v2 Crossplane usage. | ||
| func GenerateUsage(of *unstructured.Unstructured, by *unstructured.Unstructured, rd bool, usageVersion v1beta1.UsageVersion) map[string]any { |
Member
There was a problem hiding this comment.
Suggested change
| func GenerateUsage(of *unstructured.Unstructured, by *unstructured.Unstructured, rd bool, usageVersion v1beta1.UsageVersion) map[string]any { | |
| func GenerateUsage(of, by *unstructured.Unstructured, rd bool, usageVersion v1beta1.UsageVersion) map[string]any { |
Nit: You only need the type once when they're repeated in Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added support for sequencing of resource deletion using the resource dependency graph.
Usageand/orClusterUsageresources are created based on the dependencies used for resource creation. Supports both Crossplane v1Usage.apiextension.crossplane.ioand Crossplane v2Usage.protection.crossplane.io/ClusterUsage.protection.crossplane.ioresources.Fixes #79
I have: