Skip to content

ci: Remove image promotion steps#22

Merged
adamwg merged 1 commit into
crossplane:mainfrom
adamwg:awg/promote-images
May 21, 2026
Merged

ci: Remove image promotion steps#22
adamwg merged 1 commit into
crossplane:mainfrom
adamwg:awg/promote-images

Conversation

@adamwg
Copy link
Copy Markdown
Member

@adamwg adamwg commented May 21, 2026

Description of your changes

We don't build container images for the CLI (yet) and therefore don't have image promotion nix targets, but forgot to remove the image promotion steps from our Promote action.

I have:

We don't build container images for the CLI (yet) and therefore don't have image
promotion nix targets, but forgot to remove the image promotion steps from our
Promote action.

Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
@adamwg adamwg requested review from a team, jcogilvie and tampakrap as code owners May 21, 2026 20:06
@adamwg adamwg requested review from negz and removed request for a team May 21, 2026 20:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 40d48ae8-28cb-4a55-86f8-4c69f93c0b47

📥 Commits

Reviewing files that changed from the base of the PR and between 3e2485e and 167315d.

📒 Files selected for processing (1)
  • .github/workflows/promote.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/promote.yml

📝 Walkthrough

Walkthrough

The promotion workflow is simplified to remove container image promotion to DockerHub, Upbound, and GHCR registries. Environment variables for these registries are removed from the top-level configuration, and all associated login and promotion steps are deleted. The workflow retains only S3 artifact promotion via AWS credentials.

Changes

Promotion Workflow Simplification

Layer / File(s) Summary
Remove container registry promotion
.github/workflows/promote.yml
Environment variables for Docker and Upbound registry access are removed from the workflow top-level env. All container image login and promotion steps targeting DockerHub, Upbound, and GHCR are deleted. The workflow now proceeds directly to the remaining "Promote Artifacts to S3" step, which uses AWS credentials and receives version/channel/pre-release parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing image promotion steps from the CI workflow, which aligns perfectly with the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining why the image promotion steps are being removed and what was verified before submission.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Breaking Changes ✅ Passed All files under apis/** and cmd/** are newly added (not modified), with no removal/renaming of public fields/flags, no new required public fields in existing APIs, or removal of existing behavior.
Feature Gate Requirement ✅ Passed PR removes CI workflow steps (no new experimental features added). No changes to apis/** or CLI behavior requiring feature gates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adamwg adamwg merged commit 5a1ea69 into crossplane:main May 21, 2026
9 checks passed
@adamwg adamwg deleted the awg/promote-images branch May 21, 2026 20:11
@github-actions
Copy link
Copy Markdown

Successfully created backport PR for release-2.3:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants