ci: Remove image promotion steps#22
Conversation
We don't build container images for the CLI (yet) and therefore don't have image promotion nix targets, but forgot to remove the image promotion steps from our Promote action. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe promotion workflow is simplified to remove container image promotion to DockerHub, Upbound, and GHCR registries. Environment variables for these registries are removed from the top-level configuration, and all associated login and promotion steps are deleted. The workflow retains only S3 artifact promotion via AWS credentials. ChangesPromotion Workflow Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Successfully created backport PR for |
Description of your changes
We don't build container images for the CLI (yet) and therefore don't have image promotion nix targets, but forgot to remove the image promotion steps from our Promote action.
I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.