This repository was archived by the owner on Nov 25, 2021. It is now read-only.
add wrapper and update packaging for use by krew#33
Merged
suskin merged 1 commit intocrossplane:masterfrom Feb 18, 2020
Merged
Conversation
displague
changed the title
suskin
reviewed
Jan 17, 2020
Member
suskin
left a comment
suskin
left a comment
There was a problem hiding this comment.
Cool! 🦑
What testing has been done?
| usage | ||
| exit 1 | ||
| if [[ $# -gt 0 ]] ; then | ||
| echo "Unknown command: $1" >&2 |
bin/kubectl-crossplane-krew-wrapper
Outdated
| set -e | ||
| BASEDIR=$(dirname $(realpath "$0")) | ||
|
|
||
| PATH="${BASEDIR}:${PATH}" exec $BASEDIR/kubectl-crossplane "$@" |
Member
There was a problem hiding this comment.
Hmm I'm not super familiar with the krew idioms yet, but it seems like calling this would always result in Unknown command. What am I missing?
Member
Author
There was a problem hiding this comment.
The reasoning behind this is here, #32 (comment), based on a conversation with the Krew authors.
Member
Author
There was a problem hiding this comment.
Updated this based on a review session with @suskin
Signed-off-by: Marques Johansson <marques@upbound.io>
displague
force-pushed
the
krew-index
branch
from
de1ace7 to
033ddb0
Compare
suskin
approved these changes
Feb 18, 2020
Member
suskin
left a comment
suskin
left a comment
There was a problem hiding this comment.
Looks good to me! I paired with @displague to watch the testing of the most recent changes 🦑🦑🦑 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32 by adding LICENSE to the goreleaser tarball and adding a wrapper script for krew to use as a single point of entry for the Crossplane CLI plugins.
The (expected) krew-index manifest yaml:
https://gist.github.com/displague/444bb96b0419a036f51bf40098538a65
The plugin can be installed/tested from this branch by first removing any already installed cropssplane-cli utilities from the path and then running: