Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

Update init stack.Dockerfile#35

Open
muvaf wants to merge 2 commits intocrossplane:masterfrom
muvaf:gopackages
Open

Update init stack.Dockerfile#35
muvaf wants to merge 2 commits intocrossplane:masterfrom
muvaf:gopackages

Conversation

@muvaf
Copy link
Member

@muvaf muvaf commented Jan 10, 2020

  • Dockerfile updated for go 1.13 and alpine 3.11
  • COPY method includes all folders to cover cases where user adds another go package. Since it's multi-stage build, it should be fine to just copy everything to the build stage.

@muvaf muvaf requested a review from suskin January 10, 2020 17:31
Copy link
Member

@suskin suskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🦑

I had a nitpick, and my only other question is: what testing have we done? Otherwise, looks good to me.

I'm going to approve it in case it's already been tested, but we should test the change before merging it.

…ders to cover cases where user adds another go package

Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
… additions are made

Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
@muvaf
Copy link
Member Author

muvaf commented Feb 20, 2020

@suskin I tested this by creating a new project and api via kubebuilder and then running init and build functions of the cli.

@suskin I made an addition of .dockerignore and also removed the if statements that would not add .gitignore if it doesn't exist because I thought this command might be run in a folder where git init will be run later and/or .gitignore is not added yet because it's pretty much the beginning of a project. Let me know what you think.

@suskin It's been rebased, feel free to merge the PR if you think the changes are OK.

@muvaf muvaf assigned suskin and unassigned muvaf Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants