Conversation
muvaf
commented
Jan 10, 2020
- Dockerfile updated for go 1.13 and alpine 3.11
- COPY method includes all folders to cover cases where user adds another go package. Since it's multi-stage build, it should be fine to just copy everything to the build stage.
suskin
left a comment
There was a problem hiding this comment.
Awesome! 🦑
I had a nitpick, and my only other question is: what testing have we done? Otherwise, looks good to me.
I'm going to approve it in case it's already been tested, but we should test the change before merging it.
…ders to cover cases where user adds another go package Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
… additions are made Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
|
@suskin I tested this by creating a new project and api via kubebuilder and then running @suskin I made an addition of @suskin It's been rebased, feel free to merge the PR if you think the changes are OK. |