Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

[WIP] stacks: Put CRD yaml files in apiGroup directories#43

Open
displague wants to merge 2 commits intocrossplane:masterfrom
displague:crd-group-dirs
Open

[WIP] stacks: Put CRD yaml files in apiGroup directories#43
displague wants to merge 2 commits intocrossplane:masterfrom
displague:crd-group-dirs

Conversation

@displague
Copy link
Member

@displague displague commented Mar 4, 2020

Borrows from crossplane-contrib/provider-gcp#190 (@hasheddan) so future stacks can benefit from using the API group in the Stack .resource/ tree.

Adds the default app.yaml APIVersion of 0.1.0 in a separate commit which can be moved to another PR if preferred.

WIP - because this hasn't been run yet

Signed-off-by: Marques Johansson <marques@upbound.io>
Borrows from crossplane-contrib/provider-gcp#190

Signed-off-by: Marques Johansson <marques@upbound.io>
@displague displague changed the title stacks: Put CRD yaml files in apiGroup directories [not tested] stacks: Put CRD yaml files in apiGroup directories Mar 4, 2020
@displague displague changed the title [not tested] stacks: Put CRD yaml files in apiGroup directories [WIP stacks: Put CRD yaml files in apiGroup directories Mar 4, 2020
@displague displague changed the title [WIP stacks: Put CRD yaml files in apiGroup directories [WIP] stacks: Put CRD yaml files in apiGroup directories Mar 4, 2020
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants