Remove references to controller-runtime/pkg/ratelimiter#777
Closed
tnthornton wants to merge 1 commit intocrossplane:mainfrom
Closed
Remove references to controller-runtime/pkg/ratelimiter#777tnthornton wants to merge 1 commit intocrossplane:mainfrom
tnthornton wants to merge 1 commit intocrossplane:mainfrom
Conversation
Member
Author
|
Looks like was on an old changeset. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
As part of kubernetes-sigs/controller-runtime#2799, the
ratelimiterpackage was removed from controller-runtime here.Anything project pulling in crossplane-runtime and referencing the ratelimiter package will run into problems as they go to upgrade to more recent versions.
This changeset gets in front of this a little by directly referencing the RateLimiter interface from client-go, which was copied into controller-runtime.
I have:
- [ ] Runearthly +reviewableto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.