fix(angryjet): rename helpers to convert

[Duologic]

Description of your changes

Follow up on #91, this rename was forgotten there.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've been running this for generating https://github.com/grafana/crossplane-provider-grafana/

I did have to update the generated code intermittently as I couldn't run go mod tidy or make generate because of this rename. Not sure if qualifies as a breaking change.

[Duologic]

I'm getting a lint error locally:

11:37:49 [ .. ] golangci-lint
WARN [runner] Can't run linter goanalysis_metalinter: buildssa: failed to load package ast: could not load export data: internal error in importing "go/ast" (unsupported version: 2); please report an issue
ERRO Running error: can't run linter goanalysis_metalinter
buildssa: failed to load package ast: could not load export data: internal error in importing "go/ast" (unsupported version: 2); please report an issue
11:37:51 [FAIL]

Not sure how to solve that.

[Duologic]

Updating golangci-lint seems to help...

[jbw976]

Thanks for this contribution @Duologic! What do you think about updating ALL the mentions of helper while we're at it? 😂

[jbw976]

if we want to be thorough, we could also update the name of this function argument in its signature/implementation too - it's currently still helpersPkgPath: https://github.com/crossplane/crossplane-tools/blob/master/internal/method/resolver.go#L32

And then in multiResolutionCall():
https://github.com/crossplane/crossplane-tools/blob/master/internal/method/resolver.go#L165

And then in the resolver tests too, e.g.:

• https://github.com/crossplane/crossplane-tools/blob/master/internal/method/resolver_test.go#L323
• https://github.com/crossplane/crossplane-tools/blob/master/internal/method/resolver_test.go#L108
• https://github.com/crossplane/crossplane-tools/blob/master/internal/method/resolver_test.go#L273
• https://github.com/crossplane/crossplane-tools/blob/master/internal/method/resolver_test.go#L285

[Duologic]

Great, I'll do that. Interesting that this isn't catched by linting or another CI test. 🤔

[jbw976]

awesome @Duologic - just drop another message here when you're done and we'll take another look!

[Duologic]

@jbw976 done, grepped for 'helper' and replaced what I found.

[jbw976]

cool, this looks good to me @Duologic, thanks for the follow up! 🙇‍♂️