Chore: replace wildcard imports with list of all classes#151
Chore: replace wildcard imports with list of all classes#151dmsmith merged 1 commit intocrosswire:masterfrom
Conversation
|
For ordering, CrossWire first. Then library imports, such as Lucene. Then Java. Alphabetic within each. Basic idea is most important to least important. Statics are new to JSword. We had been maintaining JSword for Java 5. We are now on Java 7 with some Java 8 features implemented in Android's earlier implementation of Java. Statics obscure the class from where they are from. No opinion where they should be. Any thoughts? I'd hope that organizing imports would be easy. I know Eclipse allows a file describing the ordering of imports. |
|
In all the other projects I work on the static import statements come first. So the list would be something like: import static * If this is acceptable I will start updating files in small groups so it is easier to review and approve. |
|
I'm fine with that but.... If you'd like to help with that, that'd be great. I started stepbible-integrate branch for that. It is not current with master which was just updated from andbible-integrate. |
It appears from reading the checkstyle files that avoiding wildcard imports is the preference for the project.
BTW, is there a preferred ordering of imports? Alphabetic order? Static imports first? Crosswire classes first? Something else?