[Bug] Spammed Commands with Queue + Delay + Cooldown Ignores Cooldown

[CrowbarToolsRobot]

Description

Enabling command cooldowns with a queued effects list containing a delay effect results in cooldowns being ignored during the delay execution, but not during (most?) other effects in the list. That specific command received during the delay just executes without regard to cooldown once the prior delay elapses and the cooldown has elapsed.

Steps to Reproduce

1. Add a command.
2. Give it a cooldown.
3. Add the effects list to a Queue (maybe optional?).
4. Give it a Delay Effect.
5. Give it a Chat effect to know when it actually executes.
6. Spam the command.

Expected Behavior

The first execution after cooldown expires to succeed and reinstate the cooldown. Currently, all invocations during the delay will be executed.

Firebot Version

v5.63.2

Submitted By

phroggie

Created via Discord.

[CKY-]

Firebot/src/backend/chat/commands/chat-command-handler.ts

Line 255 in 2321e27

commandCooldownManager.cooldownCommand(command, triggeredSubcmd, commandSender);

is misbehaving and alowing the cooldown to be 0 when it is sent many times over