-
-
Notifications
You must be signed in to change notification settings - Fork 125
Closed
Labels
Dev ApprovedThe issue has been approved by a team member and can be worked on.The issue has been approved by a team member and can be worked on.Dev Complete
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
Update notification alerts use a toastClass of "warn" when "warning" was likely intended.
ngToast/Bootstrap-css provide for several alert classes: ["success", 'info", "warning", "danger"], of which "warn" is not in this list. Additionally, "warn" does not appear anywhere else in the code base, excluding logger.warn and an (unused) Twitch warn event. As such, this was likely a mere misspelling. However, it's possible that this is in-fact not a bug, and is intended behavior.
ngToast docs (unversioned)
Bootstrap 3.4 docs
Expected Behavior
Toast that is properly browned, but not burned.
Steps To Reproduce
- Start the Firebot nightly or run from source in the v5 branch.
- Add and commit an "update" message to the metadata branch in notifications/notifications.json.
- Wait for the toast to cook.
Version
5.64-sources
What operating system are you using Firebot on?
Windows 10
Relevant log output
No response
Contact Details (Optional)
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Dev ApprovedThe issue has been approved by a team member and can be worked on.The issue has been approved by a team member and can be worked on.Dev Complete
Type
Projects
Status
Todo