Feat: Add $effectQueueLength variable#2533
Merged
SReject merged 4 commits intocrowbartools:v5from Jun 29, 2024
Merged
Conversation
…s api on getItem call
codehdn
commented
May 2, 2024
|
|
||
| item.queue = effectQueueRunner.getQueue(itemId); | ||
|
|
||
| item.length = item.queue.length; |
Contributor
Author
There was a problem hiding this comment.
adding this so the express api also has easy access to this value. Its present when calling for all queues but not individual queues so assume just a small oversight.
Collaborator
There was a problem hiding this comment.
When I implemented that originally, the paradigm was "fetch all queues, get length. Fetch specific queue, get the array of items instead for more advanced use"
the intention there was that if you needed the length, you'd get it from the array as the array is already present.
Contributor
Author
There was a problem hiding this comment.
Completely get it, I'm adding it for the less capable tools that can fetch against the api but only take the json key and don't permit any type of count/logic capabilities.
SReject
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
I've added a new text variable "effectQueueLength" as a utility variable. This variable takes in a queue name
Applicable Issues
#2513
Testing
Screenshots
Selecting the variable:



Primary use case:
Bad queue case: