Mark user active on channel point redemption#2542
Merged
ebiggz merged 3 commits intocrowbartools:v5from Jul 18, 2024
Merged
Conversation
ebiggz
approved these changes
Jul 18, 2024
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Marks a user active on channel point redemption. Updates RewardRedemptionMetadata type to include userId and userDisplayName, these then get checked on the triggerChannelReward method to make sure theyre truthy, if theyre not it is assumed the streamer triggered the use of the channel reward and as such doesnt mark the user active.
Applicable Issues
#2537
Testing
I dont have a affiliate twitch account at this time so I have not personally tested this change
For testing I would setup a channel reward
have a user join chat and wait for it to become inactive
have that same user redeem a channel reward and verify they become active
also need to test for when a user is not in the chat user list yet (CKY mentioned possible weirdness here)
Need to test what happens when the redemption gets put into an effect queue, does it still mark user active or does it assume the streamer sent it in
Per CKY testing in the discord:
" this change is working as advertised.
there was a flutter when a user who was not in the list appeared after using a redeem
i would say PR it and let the core team have a look"
Screenshots
None