Channel Rewards: Effects & Events on Approve/Reject#2572
Merged
SReject merged 8 commits intocrowbartools:v5from Jul 17, 2024
Merged
Channel Rewards: Effects & Events on Approve/Reject#2572SReject merged 8 commits intocrowbartools:v5from
SReject merged 8 commits intocrowbartools:v5from
Conversation
SReject
approved these changes
Jun 29, 2024
SReject
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Applicable Issues
#2561
Testing
Ensured other effect lists disappear when redemption queue is skipped
Ensured effects added to these effect boxes run when the appropriate trigger happens
Ensured "Approved" effects don't run when queue is skipped and a redemption happens
Ensured both events fire when the appropriate trigger happens
Ensured "Approved" event doesn't fire when queue is skipped and a redemption happens
Ensured rewards and restrictions for When Redeemed are synchronized when changing "Skip Twitch Reward Requests Queue"
Screenshots