Skip to content

Channel Rewards: Effects & Events on Approve/Reject#2572

Merged
SReject merged 8 commits intocrowbartools:v5from
dennisrijsdijk:v5-channel-reward-events
Jul 17, 2024
Merged

Channel Rewards: Effects & Events on Approve/Reject#2572
SReject merged 8 commits intocrowbartools:v5from
dennisrijsdijk:v5-channel-reward-events

Conversation

@dennisrijsdijk
Copy link
Collaborator

@dennisrijsdijk dennisrijsdijk commented Jun 6, 2024

Description of the Change

  • Adds the ability to run effects when a channel reward redemption is accepted or rejected. This is only available when redemptions are added to Twitch's redemption queue
  • Adds the following events:
    • Channel Reward Redemption Approved
    • Channel Reward Redemption Rejected

Applicable Issues

#2561

Testing

Ensured other effect lists disappear when redemption queue is skipped
Ensured effects added to these effect boxes run when the appropriate trigger happens
Ensured "Approved" effects don't run when queue is skipped and a redemption happens
Ensured both events fire when the appropriate trigger happens
Ensured "Approved" event doesn't fire when queue is skipped and a redemption happens
Ensured rewards and restrictions for When Redeemed are synchronized when changing "Skip Twitch Reward Requests Queue"

Screenshots

  • Updated Verbiage regarding Rewards Requests Queue.
    • Updated the title of the setting to "Skip Twitch Reward Requests Queue"
    • Added an explicit text description of what happens when the queue is skipped

image

  • Added effect boxes for "When Approved" and "When Rejected"
    • These are only available when the reward queue is NOT skipped
    • The headers are collapsible, with "When Redeemed" shown by default
    • Restrictions are only available for "When Redeemed" effects

image
image
image

  • When "Skip Twitch Reward Requests Queue" is enabled, only the "When Redeemed" effects are shown.

image

  • Channel Reward Events

image

@dennisrijsdijk dennisrijsdijk requested a review from ebiggz as a code owner June 6, 2024 21:20
@SReject SReject merged commit d683ec1 into crowbartools:v5 Jul 17, 2024
@dennisrijsdijk dennisrijsdijk deleted the v5-channel-reward-events branch July 31, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments