Fix: windows resize with display scaling#2578
Merged
SReject merged 2 commits intocrowbartools:v5from Jun 29, 2024
Merged
Conversation
SReject
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Resets BrowserWindow bounds immediately after creation to accommodate display scaling scenarios.
Applicable Issues
Fixes #2569
See also mawie81/electron-window-state#80 (hat-tip SslTomH)
Testing
Tested in Win32 on multiple monitors, including negative of the primary monitor in both X and Y directions, in both maximized and windowed states. Tested over multiple scaling values, including non-scaled.
Solution would still ideally need to be confirmed non-breaking for OS-X and Linux, but it's hard to imagine it would be.
Screenshots
Short two-minute video of existing behavior, then application of these changes, followed by a glimpse of the Windows display settings while it recompiles, followed by the new behavior: https://www.youtube.com/watch?v=L3uRZ8vMTj4