Feat: Add filtering to Create New Setup components#2599
Merged
ebiggz merged 3 commits intocrowbartools:v5from Jul 18, 2024
Merged
Feat: Add filtering to Create New Setup components#2599ebiggz merged 3 commits intocrowbartools:v5from
ebiggz merged 3 commits intocrowbartools:v5from
Conversation
- Sorting subjectively feels to be the incorrect solution. - Instead, here's filtering, enabled for all component types. - Can filter by name, or by component ID. - As such, filtered results will likely cause additional items until 3-4 letters of the search text have been entered. Implements crowbartools#1994
Collaborator
Author
|
I'm converting this PR to a draft for the moment, as it would be really swell if filtering picked up on the grouping tags, and it's going to take me at least a day to figure that all out. |
This is pretty slick now, but I think I need to display the tags. Three steps forward, two steps back? Or is this 2-3?
ebiggz
approved these changes
Jul 18, 2024
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
This is great! Thanks for putting it together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds filtering to the Create New Setup component dialogs per the linked feature request issue. Sorting subjectively feels to be the less helpful solution, especially if all of the desired components are already likely sorted/grouped in the component's main tab.
Can successfully filter by component name, ID, and group/sorting tags. As such, filtered results may include seemingly erroneous items, until 3-4 characters of the name are entered. However, it may be helpful to filter by ID, so I've left that in and added this note.
Applicable Issues
#1994
@zunderscore You had this issue assigned to you, so here's a helpful ping.
Testing
Tried everything I could to break it, and it survived. I think it's armored or something. Does anyone have a rail gun, or some AP rounds to fire at it?
Screenshots
The following screen shots are mocked up to recreate the original screen shot pictured in the linked issue.
Unfiltered:
Filtered:
By ID:
Or grouping/sorting tags:
